feat: rds_cluster_snapshot_copy resource #40398
Merged
+925
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
documentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @RFHold 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
jar-b
removed
the
needs-triage
github-actions
bot
added
the
prioritized
jar-b
previously approved these changes
Dec 12, 2024
There was a problem hiding this comment.
LGTM 🎉
% make testacc PKG=rds TESTS=TestAccRDSClusterSnapshotCopy_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSClusterSnapshotCopy_' -timeout 360m
2024/12/12 15:40:56 Initializing Terraform AWS Provider...
--- PASS: TestAccRDSClusterSnapshotCopy_kmsKeyID (217.88s)
--- PASS: TestAccRDSClusterSnapshotCopy_destinationRegion (227.03s)
--- PASS: TestAccRDSClusterSnapshotCopy_disappears (228.51s)
--- PASS: TestAccRDSClusterSnapshotCopy_basic (230.86s)
--- PASS: TestAccRDSClusterSnapshotCopy_tags (238.90s)
--- PASS: TestAccRDSClusterSnapshotCopy_share (369.76s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 375.068s
ewbankkit
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRDSClusterSnapshotCopy_' PKG=rds ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 4 -run=TestAccRDSClusterSnapshotCopy_ -timeout 360m
2024/12/13 10:18:16 Initializing Terraform AWS Provider...
=== RUN TestAccRDSClusterSnapshotCopy_basic
=== PAUSE TestAccRDSClusterSnapshotCopy_basic
=== RUN TestAccRDSClusterSnapshotCopy_share
=== PAUSE TestAccRDSClusterSnapshotCopy_share
=== RUN TestAccRDSClusterSnapshotCopy_tags
=== PAUSE TestAccRDSClusterSnapshotCopy_tags
=== RUN TestAccRDSClusterSnapshotCopy_disappears
=== PAUSE TestAccRDSClusterSnapshotCopy_disappears
=== RUN TestAccRDSClusterSnapshotCopy_destinationRegion
=== PAUSE TestAccRDSClusterSnapshotCopy_destinationRegion
=== RUN TestAccRDSClusterSnapshotCopy_kmsKeyID
=== PAUSE TestAccRDSClusterSnapshotCopy_kmsKeyID
=== CONT TestAccRDSClusterSnapshotCopy_basic
=== CONT TestAccRDSClusterSnapshotCopy_disappears
=== CONT TestAccRDSClusterSnapshotCopy_tags
=== CONT TestAccRDSClusterSnapshotCopy_share
--- PASS: TestAccRDSClusterSnapshotCopy_disappears (207.10s)
=== CONT TestAccRDSClusterSnapshotCopy_kmsKeyID
--- PASS: TestAccRDSClusterSnapshotCopy_basic (331.28s)
=== CONT TestAccRDSClusterSnapshotCopy_destinationRegion
--- PASS: TestAccRDSClusterSnapshotCopy_share (340.16s)
--- PASS: TestAccRDSClusterSnapshotCopy_tags (349.14s)
--- PASS: TestAccRDSClusterSnapshotCopy_kmsKeyID (246.14s)
--- PASS: TestAccRDSClusterSnapshotCopy_destinationRegion (254.84s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 591.589s
|
Thanks for your contribution, @RFHold! 👍 |
github-actions
bot
removed
the
prioritized
|
This functionality has been released in v5.82.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a resource
aws_db_cluster_snapshot_copy, which behaves similarly to an existingaws_db_snapshot_copyresource.Relations
Closes #27926.
Closes #39230.
Closes #40429.
References
https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_CopyDBClusterSnapshot.html
Output from Acceptance Testing